[CRIU] [PATCH] zdtm:Makefile increase wait timeout

Andrew Vagin avagin at parallels.com
Wed Oct 22 10:38:56 PDT 2014


On Wed, Oct 22, 2014 at 05:10:58PM +0400, Konstantin Neumoin wrote:
> This timeout is too small for tcp test cases.
> This timeout should be bigger than TCP_RTO_MAX 120 seconds

TCP_RTO_MAX is a maximum timeout to retransmit data, but we need time to
handle data and to print result. I suggest to set the wait timeout into
TCP_RTO_MAX * 2

> 
> Signed-off-by: Konstantin Neumoin <kneumoin at parallels.com>
> ---
>  test/zdtm/live/static/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/zdtm/live/static/Makefile b/test/zdtm/live/static/Makefile
> index e9cac39..e9c2fd6 100644
> --- a/test/zdtm/live/static/Makefile
> +++ b/test/zdtm/live/static/Makefile
> @@ -256,9 +256,9 @@ check_start:	$(PID:%.pid=%.is_running)
>  stop:	$(STATE_OUT)
>  	-kill -TERM `cat *.pid`
>  
> -WAIT_TIME=10
> +WAIT_TIME=120
>  wait_stop:
> -	-for ((i = 0; i < $(WAIT_TIME); i++)); do \
> +	for ((i = 0; i < $(WAIT_TIME); i++)); do \
>  		kill -0 `cat *.pid 2>/dev/null` 2>/dev/null || break; \
>  		sleep 1; \
>  	done
> -- 
> 1.7.11.7
> 


More information about the CRIU mailing list