[CRIU] [PATCH 0/9] tty: Use regular files engine to save paths to the peers, v4

Tycho Andersen tycho.andersen at canonical.com
Fri Oct 17 02:13:22 PDT 2014


On Fri, Oct 17, 2014 at 04:12:23AM -0500, Tycho Andersen wrote:
> Hi Cyrill,
> 
> On Thu, Oct 16, 2014 at 02:27:19PM +0400, Cyrill Gorcunov wrote:
> > Hi, here is an updated series, hopefully I addressed all the concerns.
> > Please take a look (I pushed it into tty-5 branch).
> 
> I tried this patchset and it dumps and restores for me, although my
> question about how to really test is still there. I tried tail
> /dev/console in one terminal and echo "foo" | sudo tee /dev/console in
> another and didn't see anything, but I'm not really sure if that
> should work or not (it doesn't on a normal /dev/console).

Also, I am happy to merge this:

Acked-by: Tycho Andersen <tycho.andersen at canonical.com>

> Tycho
> 
> > Cyrill Gorcunov (9):
> >   tty: Introduce tty types
> >   tty: parasite -- Don't call for TIOCGPKT/TIOCGPTLCK on non-ptys
> >   tty: Parse slave peer index from fd_parms
> >   files: Add file_desc_init helper
> >   files-reg: Export do_open_reg_noseek_flags
> >   files-reg: Strip off "(deleted)" postfix on ghost files
> >   files-reg: Don't generate ghost files for hanged out slave pty peers
> >   tty: Use regular files engine to save paths to the peers, v4
> >   tty: Add support of /dev/console
> > 
> >  files-reg.c                |  43 ++++-
> >  files.c                    |  28 +++-
> >  include/files-reg.h        |   1 +
> >  include/files.h            |   1 +
> >  include/parasite-syscall.h |   2 +-
> >  include/parasite.h         |   1 +
> >  include/tty.h              |  39 +++++
> >  parasite-syscall.c         |   3 +-
> >  pie/parasite.c             |  60 +++----
> >  protobuf/tty.proto         |   1 +
> >  tty.c                      | 406 ++++++++++++++++++++++++++++++++++-----------
> >  11 files changed, 444 insertions(+), 141 deletions(-)
> > 
> > -- 
> > 1.9.3
> > 


More information about the CRIU mailing list