[CRIU] [PATCH 5/5] tty: Use regular files engine to save paths to the peers, v3

Cyrill Gorcunov gorcunov at gmail.com
Wed Oct 15 03:05:40 PDT 2014


On Wed, Oct 15, 2014 at 01:59:39PM +0400, Cyrill Gorcunov wrote:
> 
> If there are images created with older criu -- there won't be reg-files records
> but I need to the rest of code to use reg-files engine (ie the code will be unified)
> so for such case I create "fake" reg-files entries.

Forgot to mention: I need fake peers for case when we're resotring slave peer with
master closed, in this case to restore we need to open master peer with proper index
then restore slave peer and close master finally.

> > 
> > This should be done on dump side. We have a problem right now with these
> > "(deleted)" for link remaps and ghosts. Just introduce the function that
> > strips this part for those and call the same for PTYs on dump.
> 
> Could you explain what problems we're facing with this postfix?

You know, I think it's a bad idea to strip them on dump -- if something goes
wrong in future having " (deleted)" in image records will be a good debug info.


More information about the CRIU mailing list