[CRIU] [PATCH 1/5] tty: Introduce TTY_TYPE

Cyrill Gorcunov gorcunov at gmail.com
Wed Oct 15 03:01:24 PDT 2014


On Wed, Oct 15, 2014 at 01:57:45PM +0400, Pavel Emelyanov wrote:
> >>>  	switch (major) {
> >>> -	case UNIX98_PTY_SLAVE_MAJOR:
> >>>  	case TTYAUX_MAJOR:
> >>> -		return tty_types[major];
> >>> +		if (minor == 0 || minor == 2)
> >>
> >> The comparison of minor first appeared in this patch which makes
> >> it not just "introduce the type" but also "fix some bug".
> > 
> > Nope. Not testing minors earlier simply defering exit, 
> 
> Where is this place currently in the code?

parse_pty_index, /dev/console get treated as master pty peer and
of course ioctl doesn't work on it (because /dev/console is a special
slave peer)


More information about the CRIU mailing list