[CRIU] [PATCH 0/5] tty: Use reg-files engine to save paths to tty peers

[Tycho Andersen]

Hi Cyrill,

On Mon, Oct 13, 2014 at 07:51:47PM +0400, Cyrill Gorcunov wrote:
> Hopefully this time all issues are addressed. Please take a look.
> Once series get merged I'll implement /dev/console support.

When I try with this patchset on a container that has been restored
(i.e. the case that failed last time with the ioctl error), I now get:

(00.259398) Error (files-ext.c:91): Can't dump file 0 of that type [20660] (chr 5:1)

I guess this is related to the underlying problem? Actually I don't
understand how criu can restore ttys, doesn't something else have to
set them up and tell criu that they were bind mounted correctly?

Tycho

> Cyrill Gorcunov (5):
>   tty: Introduce TTY_TYPE
>   tty: parasite -- Don't call for TIOCGPKT/TIOCGPTLCK on non-ptys
>   tty: Parse slave peer index from fd_parms
>   files: Add file_desc_init helper
>   tty: Use regular files engine to save paths to the peers, v3
> 
>  files-reg.c                |   8 ++
>  files.c                    |  28 ++--
>  include/files.h            |   1 +
>  include/parasite-syscall.h |   2 +-
>  include/parasite.h         |   1 +
>  include/tty.h              |  16 +++
>  parasite-syscall.c         |   3 +-
>  pie/parasite.c             |  60 ++++----
>  tty.c                      | 352 ++++++++++++++++++++++++++++++++++++---------
>  9 files changed, 361 insertions(+), 110 deletions(-)
> 
> -- 
> 1.9.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu