[CRIU] [PATCH 4/9] pycriu: add python package

Pavel Emelyanov xemul at parallels.com
Wed Oct 8 09:18:47 PDT 2014


On 10/08/2014 08:13 PM, Cyrill Gorcunov wrote:
> On Wed, Oct 08, 2014 at 08:04:45PM +0400, Pavel Emelyanov wrote:
>>
>>> --- /dev/null
>>> +++ b/pycriu/images/Makefile
>>> @@ -0,0 +1,17 @@
>>> +all: protobuf magic.py
>>> +
>>> +.PHONY: all protobuf clean
>>> +
>>> +# We don't need rpc_pb2.py here, as it is not related to the
>>> +# images.
>>> +# Unfortunately, we can't drop ugly _pb2 suffixes here, because
>>> +# some _pb2 files depend on others _pb2 files.
>>> +protobuf:
>>> +	$(Q) cp $(SRC_DIR)/protobuf/*_pb2.py ./ ; rm rpc_pb2.py
>>
>> Wow... Cyrill, can we do it in a nicer way?
> 
> Oh, protobuf double deps, how nice ;) We've had this in criu
> (or some sort of) and been fixed in making two passes
> 
>  1) Generate pre-deps
>  2) Generate deps themslef
> 
> I'll take a look.

If we can make .py files stay in protobuf/ directory but
all .py scripts pick them up from there -- this would be OK.



More information about the CRIU mailing list