[CRIU] [PATCH 1/6] Replace PAGE_SIZE in vaddr_to_pfn

Cyrill Gorcunov gorcunov at gmail.com
Wed Oct 8 06:19:50 PDT 2014


On Wed, Oct 08, 2014 at 09:03:32AM -0400, Christopher Covington wrote:
> > 
> > Yeah, looks good to me. Even more -- in our build engine we can investigate
> > the page size and move PAGE_SIZE into config.h (I suppose arm doesn't run
> > kernel with different page sizes simultaneously, right?)
> 
> For a given kernel the PAGE_SIZE will be constant. However, I'd like for an
> AArch64 CRIU built on one kernel (or cross-compiled) to work on as many other
> kernels as possible, in particular those with different PAGE_SIZE and TASK_SIZE.

I see. Sorry for confusion from my side.

> 
> > IOW we can do something (in Makefile.config)
> > 
> > ifeq ($(ARCH),arm)
> > ifeq ($(call try-cc,$(PAGE_SIZE_TEST_65536),),y)
> > 	$(Q) @echo '#define CONFIG_PAGE_SIZE 65536' >> $@
> > elseif ($(call try-cc,$(PAGE_SIZE_TEST_4096),),y)
> > 	$(Q) @echo '#define CONFIG_PAGE_SIZE 4096' >> $@
> > endif
> > endif
> 
> Just to clarify, this only affects 64-bit ARM ("AArch64"), ARCH=aarch64.
> 32-bit ARM ("AArch32"), ARCH=arm, only has a 4K PAGE_SIZE.
> 
	Cyrill


More information about the CRIU mailing list