[CRIU] Fix cpuset restore-in-root bug

[Tycho Andersen]

On Tue, Oct 07, 2014 at 11:15:34PM +0400, Pavel Emelyanov wrote:
> On 10/07/2014 06:16 PM, Tycho Andersen wrote:
> > Hi Pavel,
> > 
> > On Tue, Oct 07, 2014 at 12:58:34PM +0400, Pavel Emelyanov wrote:
> >> On 10/06/2014 06:03 PM, Tycho Andersen wrote:
> >>> Hi all,
> >>>
> >>> Based on some discussion, we shouldn't try to do any intelligent copying of any
> >>> properties anywhere else in the tree. These cpuset properties are special only
> >>> in the sense that they need to be restored before the move_in_cgroup call, and
> >>> if the parent cgroups have conflicting options (or empty options), it is best
> >>> to just let the restore fail.
> >>
> >> Patches applied, thanks!
> >>
> >>> Also, I noticed when making this patch that I am getting a lot of:
> >>>
> >>> (00.092575)    290: Error (util.c:101): Unable to close fd 1016: Bad file descriptor
> >>
> >> Ouch. Can you show the full log please?
> > 
> > Yes, these are with the current master:
> > 
> > http://paste.ubuntu.com/8514798/
> 
> Hm... I've run cgroup* tests on recent HEAD and no errors in logs.
> 
> > also, 1016 is the cg service fd, so it seems like maybe a recent
> > reordering broke something? I can do a bisect if you take a look at
> > the log and nothing obvious pops out.
> 
> Yes, please. If you would be able to shed more light on this, that
> would be awesome.

Hmm. I tried to bisect with a patch that I know I wasn't seeing this
problem with, but even that one has this issue now. Something about my
environment must have changed, I guess? I will investigate more and
keep you posted.

Tycho