[CRIU] Fix cpuset restore-in-root bug

Tycho Andersen tycho.andersen at canonical.com
Tue Oct 7 07:16:41 PDT 2014


Hi Pavel,

On Tue, Oct 07, 2014 at 12:58:34PM +0400, Pavel Emelyanov wrote:
> On 10/06/2014 06:03 PM, Tycho Andersen wrote:
> > Hi all,
> > 
> > Based on some discussion, we shouldn't try to do any intelligent copying of any
> > properties anywhere else in the tree. These cpuset properties are special only
> > in the sense that they need to be restored before the move_in_cgroup call, and
> > if the parent cgroups have conflicting options (or empty options), it is best
> > to just let the restore fail.
> 
> Patches applied, thanks!
> 
> > Also, I noticed when making this patch that I am getting a lot of:
> > 
> > (00.092575)    290: Error (util.c:101): Unable to close fd 1016: Bad file descriptor
> 
> Ouch. Can you show the full log please?

Yes, these are with the current master:

http://paste.ubuntu.com/8514798/

also, 1016 is the cg service fd, so it seems like maybe a recent
reordering broke something? I can do a bisect if you take a look at
the log and nothing obvious pops out.

Tycho

> > but it seems to be unrelated (i.e. these occurr on git master).
> 


More information about the CRIU mailing list