[CRIU] [PATCH 00/11] tty layer rework, v3

Tycho Andersen tycho.andersen at canonical.com
Mon Oct 6 09:14:20 PDT 2014


Hi Cyrill,

On Mon, Oct 06, 2014 at 07:14:57PM +0400, Cyrill Gorcunov wrote:
> On Mon, Oct 06, 2014 at 09:17:47AM -0500, Tycho Andersen wrote:
> > Hi Cyrill,
> > 
> > On Mon, Oct 06, 2014 at 05:15:39PM +0400, Cyrill Gorcunov wrote:
> > > Here we jump into using regfiles engine in tty code.
> > > I think here are some nits left here and there but
> > > they can be polished on top. Please give it a shot.
> 
> Tycho, could you please apply the patch on top of this series
> and give it a try?

I tried this patch, but it didn't fix the issue for me. However, my
patch applied at a slightly different line no. (on current master with
your series on top) than 802 listed below. Am I missing some patches
that need to be applied before this?

Tycho

> From ca017cccbae07229c1ce19555e64efc995fa26d7 Mon Sep 17 00:00:00 2001
> From: Cyrill Gorcunov <gorcunov at openvz.org>
> Date: Mon, 6 Oct 2014 19:11:31 +0400
> Subject: [PATCH] tty: Fix ptmx opening
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tty.c b/tty.c
> index 39215ef205d8..48a7c9e532b7 100644
> --- a/tty.c
> +++ b/tty.c
> @@ -802,7 +802,7 @@ static int pty_open_ptmx(struct tty_info *info)
>  {
>  	int master = -1;
>  
> -	master = pty_open_ptmx_index(info, info->tie->pty->index);
> +	master = pty_open_ptmx_index(info, info->tfe->flags);
>  	if (master < 0) {
>  		pr_perror("Can't open %x (index %d)",
>  			  info->tfe->id, info->tie->pty->index);
> -- 
> 1.9.3
> 



More information about the CRIU mailing list