[CRIU] [PATCH 00/11] tty layer rework, v3

[Tycho Andersen]

Hi Cyrill,

On Mon, Oct 06, 2014 at 05:15:39PM +0400, Cyrill Gorcunov wrote:
> Here we jump into using regfiles engine in tty code.
> I think here are some nits left here and there but
> they can be polished on top. Please give it a shot.
> 
> Cyrill Gorcunov (11):
>   tty: Align members in assignments
>   tty: Instead of BUG_ON exit out with error early
>   tty: Introduce dump_one_tty helper
>   tty: Add some comments about console and bsd terminals
>   tty: Rename helpers to reflect the type of peers
>   tty: Carry @minor in tty_info and tty_dump_info
>   tty: Rework tty_type to account minor number
>   tty: collect_one_tty -- Use tty_is_master helper
>   tty: proto -- Add comments on some fields
>   tty: Parse slave index from link path
>   tty: Use regular files engine to save paths to the peers

With these applied, when trying to c/r an LXC container, I get:

(00.053127)      1: Error (files-reg.c:91): Can't create node for ghost dev: Operation not permitted

Full log is here, if you're interested:
http://paste.ubuntu.com/8507619/

Tycho

>  files.c            |   4 +
>  protobuf/tty.proto |   4 +-
>  tty.c              | 384 ++++++++++++++++++++++++++++++++++++++++-------------
>  3 files changed, 301 insertions(+), 91 deletions(-)
> 
> -- 
> 1.9.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu