[CRIU] [PATCH] zdtm.sh: don't change owner of a test directory

Christopher Covington cov at codeaurora.org
Fri Oct 3 08:05:17 PDT 2014


On 10/03/2014 11:01 AM, Christopher Covington wrote:
> On 10/03/2014 09:44 AM, Andrey Vagin wrote:
>> After changing an owner the current user will not be able to remove or
>> change the directory. It isn't convenient.
>>
>> Reported-by: Tycho Andersen <tycho.andersen at canonical.com>
>> Signed-off-by: Andrey Vagin <avagin at openvz.org>
>> ---
>>  test/zdtm.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/zdtm.sh b/test/zdtm.sh
>> index b5133c3..9a2c188 100755
>> --- a/test/zdtm.sh
>> +++ b/test/zdtm.sh
>> @@ -407,7 +407,7 @@ start_test()
>>  	if ! echo $TEST_SUID_LIST | grep -q $tname; then
>>  		export ZDTM_UID=18943
>>  		export ZDTM_GID=58467
>> -		chown $ZDTM_UID:$ZDTM_GID $tdir
>> +		chmod a+w $tdir
> 
> I think the variables can be deleted. I don't seem them used elsewhere.

I spoke too soon. Sorry for the noise.

zdtm/lib/test.c:        val = getenv("ZDTM_GID");
zdtm/lib/test.c:        val = getenv("ZDTM_UID");

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.


More information about the CRIU mailing list