[CRIU] [PATCH] cpuinfo: Don't report negative values to shell

Cyrill Gorcunov gorcunov at gmail.com
Fri Oct 3 04:04:35 PDT 2014


On Fri, Oct 03, 2014 at 03:00:56PM +0400, Pavel Emelyanov wrote:
> On 10/03/2014 02:48 PM, Cyrill Gorcunov wrote:
> > On Fri, Oct 03, 2014 at 02:42:11PM +0400, Pavel Emelyanov wrote:
> >> Signed-off-by: Pavel Emelyanov <xemul at parallels.com>
> > 
> > Maybe better would be to make so on higher level, ie in caller code?
> 
> Why better?

Because this code lives deep in source code tree so that you
always have to bear in mind that this function returns result
directly to shell. I don't like it. I think it's easier to
keep such convention in one place, ie in crtools.c. But sure
it's up to you, I can live with that (thus ack if needed).


More information about the CRIU mailing list