[CRIU] Preserve the "dumpable" flag on criu dump/restore.

Filipe Brandenburger filbranden at google.com
Mon May 12 17:01:22 PDT 2014


Hi,

On Mon, May 12, 2014 at 4:42 PM, Filipe Brandenburger
<filbranden at google.com> wrote:
> My last finding was that paddr = decode_pointer(vma->premmaped_addr),
> which is the last command in that same loop, and is what is supposed
> to trigger the COW code (doing a memcmp and only memcpy if they
> differ) is always getting a NULL pointer. It looks to me that
> vma->premapped_addr is the wrong thing to put there but I'm still
> trying to figure out what the right one would be...

Setting paddr = decode_pointer(p->premmaped_addr); instead seems to help...

After doing that I get many pages COWed:

(00.013729)  17521: nr_restored_pages: 182
(00.013731)  17521: nr_compared_pages: 370
(00.013733)  17521: nr_shared_pages:   188
(00.013735)  17521: nr_droped_pages:   35

However, that introduces many fails like the one below:

16:59:15.995: 17521: FAIL: cow01.c:151: 1: 0x2b35fff8f000 data mismatch

Will keep looking.

Cheers,
Filipe


More information about the CRIU mailing list