[CRIU] [PATCH] page-pipe: Don't increase the page_pipe::nr_pipes if we reuse pipes

Pavel Emelyanov xemul at parallels.com
Wed May 7 10:01:55 PDT 2014


On 05/06/2014 10:38 PM, Andrew Vagin wrote:
> On Tue, May 06, 2014 at 06:57:01PM +0400, Cyrill Gorcunov wrote:
>> The page-pipe buffers may be reused once queued pages are
>> dumped, but we happen to increase page_pipe::nr_pipes
>> all the timer, regardless the fact where page buffer
>> came from.
>>
>> In worst scenario this may lead to incorrect -EAGAIN returned
>> from page_pipe_grow forcing calling code to create new
>> pipes. This is not critical but should be fixed.
>>
>> In other words page_pipe::nr_pipes must track _really_
>> created pipes.
> 
> Acked-by: Andrew Vagin <avagin at parallels.com>
> 
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

applied


More information about the CRIU mailing list