[CRIU] criu dump failure for devpts type

[Andrew Vagin]

Hello Amey,

I have fixed this issue, the patch is attached. Thank you for the
report.

On Fri, May 02, 2014 at 05:05:23PM -0700, Amey Deshpande wrote:
> During experiments with criu v1.3-rc1 on containers, I've seen the following
> error during checkpointing (highlights for readability):
> 
> ...
> (00.012148) Dump MNT namespace (mountpoints) 10 via 9445
> ...
> (00.012232)     type devpts source devpts 13f / @ ./dev/pts flags 20000a
> options gid=5,mode=620,ptmxmode=666,
> ...
> (00.012402) Dumping mountpoints
> ...
> (00.012459)     77: 13f:/ @ ./dev/pts
> ...
> (00.012509) Error (mount.c:497): The file system 0x13f (0x10003f) devpts ./dev/
> pts is inaccessible
> 
> After rebooting the machine, the dev IDs are presumably reset, have smaller
> values, and 'criu dump' on a similar container setup succeeds:
> 
> ...
> (01.460559) Dump MNT namespace (mountpoints) 10 via 1764
> ...
> (01.460708)     type devpts source devpts 24 / @ ./dev/pts flags 20000a options
> gid=5,mode=620,ptmxmode=666,
> ...
> (01.461076) Dumping mountpoints
> ...
> (01.461230)     72: 24:/ @ ./dev/pts
> ...
> (01.730248) Dumping finished successfully
> 
> AFAICT, 'devpts' type is handled through phys_stat_resolve_dev(), and I suspect
> that it doesn't correctly handle device numbers greater than 0xff.  Is this a
> known issue?
> 
> Thanks,
> Amey
> 

> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu