[CRIU] [PATCH 2/2] service: use setproctitle

Ruslan Kuprieiev kupruser at gmail.com
Fri Mar 21 02:57:27 PDT 2014


Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
---
 cr-service.c | 20 ++++++++++++++++++++
 crtools.c    |  5 ++++-
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/cr-service.c b/cr-service.c
index 46a1004..eebcb4a 100644
--- a/cr-service.c
+++ b/cr-service.c
@@ -24,6 +24,8 @@
 #include "page-xfer.h"
 #include "net.h"
 
+#include "setproctitle.h"
+
 unsigned int service_sk_ino = -1;
 
 static int recv_criu_msg(int socket_fd, CriuReq **msg)
@@ -163,6 +165,8 @@ int send_criu_rpc_script(char *script, int fd)
 	return 0;
 }
 
+static char images_dir[PATH_MAX];
+
 static int setup_opts_from_req(int sk, CriuOpts *req)
 {
 	struct ucred ids;
@@ -198,6 +202,12 @@ static int setup_opts_from_req(int sk, CriuOpts *req)
 		return -1;
 	}
 
+	/* get full path to images_dir to use it in process title */
+	if (readlink(images_dir_path, images_dir, PATH_MAX) == -1) {
+		pr_perror("Can't readlink %s", images_dir_path);
+		return -1;
+	}
+
 	/* chdir to work dir */
 	if (req->has_work_dir_fd)
 		sprintf(work_dir_path, "/proc/%d/fd/%d", ids.pid, req->work_dir_fd);
@@ -302,6 +312,8 @@ static int dump_using_req(int sk, CriuOpts *req)
 	if (setup_opts_from_req(sk, req))
 		goto exit;
 
+	setproctitle("dump --rpc -t %d -D %s", req->pid, images_dir);
+
 	/*
 	 * FIXME -- cr_dump_tasks() may return code from custom
 	 * scripts, that can be positive. However, right now we
@@ -338,6 +350,8 @@ static int restore_using_req(int sk, CriuOpts *req)
 	if (setup_opts_from_req(sk, req))
 		goto exit;
 
+	setproctitle("restore --rpc -D %s", images_dir);
+
 	if (cr_restore_tasks())
 		goto exit;
 
@@ -358,6 +372,8 @@ static int check(int sk)
 
 	resp.type = CRIU_REQ_TYPE__CHECK;
 
+	setproctitle("check --rpc");
+
 	/* Check only minimal kernel support */
 	opts.check_ms_kernel = true;
 
@@ -384,6 +400,8 @@ static int pre_dump_using_req(int sk, CriuOpts *req)
 		if (setup_opts_from_req(sk, req))
 			goto cout;
 
+		setproctitle("pre-dump --rpc -t %d -D %s", req->pid, images_dir);
+
 		if (cr_pre_dump_tasks(req->pid))
 			goto cout;
 
@@ -447,6 +465,8 @@ static int start_page_server_req(int sk, CriuOpts *req)
 	if (setup_opts_from_req(sk, req))
 		goto out;
 
+	setproctitle("page-server --rpc");
+
 	pr_debug("Starting page server\n");
 
 	ret = cr_page_server(true);
diff --git a/crtools.c b/crtools.c
index 047ac53..d20af52 100644
--- a/crtools.c
+++ b/crtools.c
@@ -35,6 +35,8 @@
 #include "cr-service.h"
 #include "plugin.h"
 
+#include "setproctitle.h"
+
 struct cr_options opts;
 
 void init_opts(void)
@@ -114,7 +116,7 @@ Esyntax:
 	return -1;
 }
 
-int main(int argc, char *argv[])
+int main(int argc, char *argv[], char *envp[])
 {
 	pid_t pid = 0, tree_id = 0;
 	int ret = -1;
@@ -169,6 +171,7 @@ int main(int argc, char *argv[])
 
 	cr_pb_init();
 	restrict_uid(getuid(), getgid());
+	setproctitle_init(argc, argv, envp);
 
 	if (argc < 2)
 		goto usage;
-- 
1.8.3.2



More information about the CRIU mailing list