[CRIU] [PATCH] criu: Add exec-cmd option.

[Deyan Doychev]

Hi Andrew,

On 03/19/2014 10:29 PM, Andrew Vagin wrote:
>> diff --git a/crtools.c b/crtools.c
>> > index 047ac53..5591225 100644
>> > --- a/crtools.c
>> > +++ b/crtools.c
>> > @@ -77,6 +77,23 @@ bad_ns:
>> >  	return -1;
>> >  }
>> >  
>> > +char **parse_exec_cmd(char *optarg)
>> > +{
> I don't like this function. Can we use '--' to split criu options and an
> exec command
>
> ./criu restore .... --exec-cmd -- lxc-start --attach -n CTNAME --smth-else
>
> For me it looks better. What do you think about this?
>
> Thanks.
>

You're right - it looks better when the command line is split by '--'.

Will resubmit removing the function and moving its code to
setup_opts_from_req in cr_service.c so we can split exec_cmd coming from
an rpc request.

Thanks,
Deyan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openvz.org/pipermail/criu/attachments/20140320/3f08c8cc/attachment.sig>