[CRIU] [PATCH 2/3] plugin: Rework plugins API

Cyrill Gorcunov gorcunov at gmail.com
Wed Mar 12 06:03:09 PDT 2014


On Wed, Mar 12, 2014 at 04:57:43PM +0400, Andrew Vagin wrote:
> > 
> > At the moment I use @private to keep
> > 
> > +typedef struct {
> > +	struct list_head	list;
> > +	void			*dlhandle;
> > +	struct list_head	link[0];
> > +} __packed plugin_desc_t;
> > 
> > there.
> 
> Can we ask criu to allocate cr_plugin_desc_t? In this case we can
> completly hide private from users and avoid problems with supporting
> backward compatibility. What do you think about this way?

Sure we can :-) If it's preferred (the main idea in using @private was
to not call for xmalloc) I can update the series. Andrew, please reread
the series one more time, lets gather all complains (continue the list)

1) Drop off @private member, allocating it dynamically.
...


More information about the CRIU mailing list