[CRIU] [PATCH 4/5] [RFC] cr: implemented the support for the AArch64 architecture

[Christopher Covington]

Hi Alexander,

On 03/10/2014 05:26 AM, Alexander Kartashov wrote:
> Dear Cristopher,
> 
> Thank you for the valuable feedback!
> 
> Im sorry for being unresponsive for so long. Finally I've managed
> to address most issues you've pointed out, a new version of
> the patchset is to be submitted soon.

No problem. Thanks for your work on this.

>> +static inline void ksigfillset(k_rtsigset_t *set)
>> +{
>> +    int i;
>> +    for (i = 0; i < _KNSIG_WORDS; i++)
>> +        set->sig[i] = (unsigned long)-1;
>> +}
>> +
>> +#define SA_RESTORER    0x04000000
>> This is not defined in the AArch64 kernel. Since the only use is OR'd with
>> other bits, can you just define it to 0 and maybe include the "New
>> architectures should not define the obsolete SA_RESTORER" comment?
> It's still used in the kernel:
> http://lxr.free-electrons.com/source/arch/arm64/kernel/signal.c#L234
> However I didn't try to define SA_RESTORER as 0.

I see now that it's defined at
http://lxr.free-electrons.com/source/arch/arm64/include/uapi/asm/signal.h#L20
for A32 compatibility. Another candidate for the definition/include cleanup on
my someday/maybe list.

Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.