[CRIU] [PATCH] dump: do not fail dump when robust_lists are disabled

Filipe Brandenburger filbranden at google.com
Wed Jun 25 08:39:14 PDT 2014


Hi Cyrill,

On Wed, Jun 25, 2014 at 8:15 AM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:
> Actaully iirc there were a patch that de-deprecates get_robust_list ;)

Sure, I realized that, I mentioned it as an example of what could
potentially break this in the future.

> As to seccomp-bpf -- if get_robust_list get filtered and set_robust_list
> is not (and there is some data which we can't fetch from the application
> due to this reason) then we're in touble.
>
>> Do you think it would be worth adding code here to assume that the
>> list is empty only when both get_robust_list and sys_robust_list
>> return ENOSYS? I can send you an updated patch, I just wanted to know
>> your opinion before I do.
>
> Defenitely! Thanks!

I just sent you a v2 patch for this that includes the set_robust_list
check, zdtm tests pass.

I'm also resetting head and len explicitly in the case get_robust_list
returns -ENOSYS but touches the pointers, highly unlikely but I
thought it wouldn't hurt.

Cheers,
Filipe


More information about the CRIU mailing list