[CRIU] [PATCH] dump: do not fail dump when robust_lists are disabled

Cyrill Gorcunov gorcunov at gmail.com
Wed Jun 25 08:15:13 PDT 2014


On Wed, Jun 25, 2014 at 07:55:28AM -0700, Filipe Brandenburger wrote:
> Hi Cyrill,
> 
> I thought a little more about it and I wonder if we need to consider
> the case where get_robust_list is not available but set_robust_list
> is... Such a case might happen from syscall filtering (e.g. using
> seccomp-bpf for security and filtering out get_robust_list only) or
> possible deprecation of the get_robust_list syscall
> (http://marc.info/?l=linux-kernel&m=134399406131605&w=2).

Actaully iirc there were a patch that de-deprecates get_robust_list ;)
As to seccomp-bpf -- if get_robust_list get filtered and set_robust_list
is not (and there is some data which we can't fetch from the application
due to this reason) then we're in touble.

> Do you think it would be worth adding code here to assume that the
> list is empty only when both get_robust_list and sys_robust_list
> return ENOSYS? I can send you an updated patch, I just wanted to know
> your opinion before I do.

Defenitely! Thanks!


More information about the CRIU mailing list