[CRIU] [PATCH 1/2] Re-create cgroups if necessary

[Pavel Emelyanov]

On 06/24/2014 06:12 PM, Serge Hallyn wrote:

>> Yes. Emply cgroups cannot be discovered through /proc/pid/cgroup file,
>> we should walk the alive cgroup mount. But the problem is -- we cannot
>> just take the system /sys/fs/cgroup/ directories, since there will be
>> cgroups from other containers as well. We should find the root subdir
>> of the container we dump and walk _this_ subtree.
> 
> I volunteer to work on a proper cgroup c/r implementation, once Tycho
> gets the very basics done.

Serge, Tycho, I think I need to clarify one more thing.

I believe, that once we do full cgroups hierarchy restore all the
mkdirs would go away from the move_in_cgroup() routine. Instead,
we will have some code, that would construct all the cgroup subtree
before criu will start forking tasks. And once we have it, the
move_in_cgroup() would (should) never fail. Thus this patch would
be effectively reversed.

Thanks,
Pavel