[CRIU] [PATCH 0/6] Fixes and tests for dumpable flag (in particular handling fs.suid_dumpable=2)

[Filipe Brandenburger]

Ping? Just making sure this one doesn't get forgotten...

+ Andrew for patches 1 & 4 of this series which introduce zdtm tests.

Cheers,
Filipe


On Tue, Jun 17, 2014 at 8:33 PM, Filipe Brandenburger
<filbranden at google.com> wrote:
> Hi Pavel,
>
> I hope these are still in time for the 1.3.0-rc2 release tomorrow.
>
> I created two test cases, one basic test to confirm that restoring the dumpable
> flag works in the simple case and another complex one that does some gymnastics
> to get a process with the dumpable flag disabled (set to either 0 or 2
> depending on fs.suid_dumpable) dumped and restored by criu.
>
> I'm also sending the revert for Saied's temporary workaround and two minor
> cleanups in .gitignore files.
>
> Cheers!
> Filipe
>
>
> Filipe Brandenburger (6):
>   zdtm: add new dumpable01 test to check that dumpable flag is preserved
>   Revert "pie: A quick workaround for PR_SET_DUMPABLE == 2 restore
>     error."
>   restore: preserve dumpable flag when it is set to 2
>   zdtm: add new dumpable02 test to check that dumpable flag set to 0 or
>     2 works
>   zdtm: add missing entries to test/zdtm/.gitignore
>   git: add /dev to test/.gitignore
>
>  pie/restorer.c                     |  33 ++++--
>  test/.gitignore                    |   1 +
>  test/zdtm.sh                       |   2 +
>  test/zdtm/.gitignore               |   4 +
>  test/zdtm/live/static/Makefile     |   2 +
>  test/zdtm/live/static/dumpable01.c |  48 +++++++++
>  test/zdtm/live/static/dumpable02.c | 207 +++++++++++++++++++++++++++++++++++++
>  7 files changed, 291 insertions(+), 6 deletions(-)
>  create mode 100644 test/zdtm/live/static/dumpable01.c
>  create mode 100644 test/zdtm/live/static/dumpable02.c
>
> --
> 1.9.3
>