[CRIU] [PATCHv2] dump: preserve the dumpable flag on criu dump/restore

[Pavel Emelyanov]

On 06/17/2014 05:10 PM, Filipe Brandenburger wrote:
> Hi Andrew, Pavel,
> 
> On Tue, Jun 17, 2014 at 2:33 AM, Andrew Vagin <avagin at parallels.com> wrote:
>> prctl((PR_SET_DUMPABLE, 2) always fails. Filipe, do you want to
>> investigate how to handle this situation?
> 
> Yes, Saied and I were discussing this yesterday, apparently some
> versions of docker are leaving processes in dumpable==2 state and
> migration was failing with my patch...
> 
> I want to look into what is leaving processes into this dumpable==2
> state for now. I want to see if we have a good way to reproduce it on
> restore without needing to set it to 2 using prctl and if there's not
> a good way to do it, whether we can just fallback to set it to 0 in
> those cases and if that would be good enough approximation.

AFAIU 2 can happen there only if the fs.suid_dumpable sysctl is such.
Maybe if we see 2 in the images, we say, that we just inherit the
value from CRIU?

> I should be sending you more code later this week or early next week
> at the latest.

Great. Since I planned to tag 1.3-rc2 in some days, I think I will
temporary tune the restorer to ignore any mm->dumpable values other
that 0 and 1.

Thanks,
Pavel