[CRIU] [PATCH 4/5] vdso: parasite -- Prepare new vdso mark structure.

Pavel Emelyanov xemul at parallels.com
Mon Jun 16 23:48:10 PDT 2014


On 06/17/2014 10:38 AM, Cyrill Gorcunov wrote:
> On Tue, Jun 17, 2014 at 10:32:56AM +0400, Pavel Emelyanov wrote:
>>> -	m->signature = VDSO_MARK_SIGNATURE;
>>> -	m->proxy_addr = proxy_addr;
>>> +	if (m->signature == VDSO_MARK_SIGNATURE_V2) {
>>> +		/*
>>> +		 * New format
>>> +		 */
>>> +		return m->version == 2;
>>
>> If the signature is v2 one, then version _must_ be 2 here, otherwise
>> we should abort the dump. Objections?
> 
> I think so. Mind if I prepare patch on top of the series? The check
> better should be done on a caller side thus patch will not be oneliner.
> .
> 

OK


More information about the CRIU mailing list