[CRIU] [PATCH 4/5] vdso: parasite -- Prepare new vdso mark structure.

Pavel Emelyanov xemul at parallels.com
Mon Jun 16 23:32:56 PDT 2014


On 06/17/2014 02:14 AM, Cyrill Gorcunov wrote:
> 
> Because of new vvar area we need to carry the
> address of vvar proxy inside the mark. Thus
> add members needed and update routines.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  arch/x86/include/asm/vdso.h | 51 +++++++++++++++++++++++++++++++++++----------
>  arch/x86/vdso-pie.c         |  2 +-
>  arch/x86/vdso.c             |  4 ++--
>  include/parasite.h          |  3 ++-
>  pie/parasite.c              |  6 ++++--
>  5 files changed, 49 insertions(+), 17 deletions(-)
> 


> +static inline bool is_vdso_mark(void *addr)
>  {
> -	struct vdso_mark *m = where;
> +	struct vdso_mark *m = addr;
>  
> -	m->signature = VDSO_MARK_SIGNATURE;
> -	m->proxy_addr = proxy_addr;
> +	if (m->signature == VDSO_MARK_SIGNATURE_V2) {
> +		/*
> +		 * New format
> +		 */
> +		return m->version == 2;

If the signature is v2 one, then version _must_ be 2 here, otherwise
we should abort the dump. Objections?

> +	} else if (m->signature == VDSO_MARK_SIGNATURE) {



More information about the CRIU mailing list