[CRIU] [PATCH 2/3] crtools: Introduce the --ext-mount option

[Pavel Emelyanov]

On 06/03/2014 09:04 PM, Filipe Brandenburger wrote:
> Hi Pavel,
> 
> On Tue, Jun 3, 2014 at 9:29 AM, Pavel Emelyanov <xemul at parallels.com> wrote:
>> --ext-mount p<path> on restore will cause the <path> be prepended to
>> any bind mount source.
> 
> This looks a bit awkward... Why not --ext-mount p:<path> instead? This
> is analogous to the "s" option using ":" as a delimiter...

Yes, it looks nicer indeed. Current proposal was inspired by sed :)

I'd also note that p/foo is equivalent to s:/:/foo but looks nicer
and is more sed-ish. Thus it's an RFC :)

> Another option would be specific options such as --ext-mount-prepend
> and --ext-mount-substitute so that you don't need to pack the fields
> into a single one...

Agree, but then plain --ext-mount would be confusing in that case. If we
chose to go this route then there probably should be --ext-mount for dump
and --ext-mount-unchaged (or what?), --ext-mount-prepend and
--ext-mount-substitute for restore.

Thanks,
Pavel