[CRIU] [PATCH 1/2] DO NOT MERGE: Move x86 VDSO code to AArch64

Christopher Covington cov at codeaurora.org
Fri Jul 25 13:16:17 PDT 2014


On 07/25/2014 03:31 PM, Cyrill Gorcunov wrote:
> On Fri, Jul 25, 2014 at 03:19:58PM -0400, Christopher Covington wrote:
>> Purely to illustrate how exactly the AArch64 VDSO handling differs
>> from x86 in the following patch. Not intended for merge.
>>
>> Signed-off-by: Christopher Covington <cov at codeaurora.org>
> 
> Thanks a lot! I'll think how to share a common parts (presumably
> after the weekend).

Thanks Cyrill. Some notes on these changes:

I think this code triggers a bug in qemu-system-aarch64. It's either that or
there's a race condition that doesn't show up on the two other simulators I've
tried it on.

The vdso00 and vdso01 (with modifications) tests pass with my modified zdtm.sh.

I didn't yet force proxification as you suggested for testing purposes.

You brought up a point about testing changes across all architectures. I agree
that this is currently difficult. I'm currently not testing changes on x86_64
because my Ubuntu 12.04 workstation kernel version 3.2 is too old. My hope is
that we can improve this.

When you made your original changes, you sent out a call for testing that I
didn't answer because I didn't have the tests running on my system at the
time. I'm now able to mostly run the tests and should be able to respond to
such requests in the future.

I'm also working to document and improve how I cross compile and run the test
suite in QEMU using a minimal root filesystem. Once this has been streamlined,
it may be possible to integrate it into the CRIU makefiles if desired, such
that to test for x86_64, armv6, armv7, and armv8 one could simply type:

make test_multiarch

Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.


More information about the CRIU mailing list