[CRIU] [PATCH 0/4] vdso: Make it arch specific

Cyrill Gorcunov gorcunov at gmail.com
Thu Jul 24 23:56:47 PDT 2014


On Thu, Jul 24, 2014 at 04:15:51PM -0400, Christopher Covington wrote:
> Hi Cyrill,
> 
> On 05/26/2014 03:50 AM, Cyrill Gorcunov wrote:
> >   New linux kernels (starting from 3.16 presumably) will
> > have quite reworked vDSO format so that our "common" parser
> > won'y work anymore. Thus every architecture should implement
> > own vdso parsing and handling.
> 
> I copied the x86 VDSO code (903 lines) into arch/aarch64 then modified it
> until it worked on a 3.16.0-rc4+ kernel. Below is the diffstat.
> 
> M Makefile                                       +6, -0
> M arch/aarch64/include/asm/parasite-syscall.h    +1, -1
> M arch/aarch64/include/asm/vdso.h                +7, -8
> A arch/aarch64/intraprocedure.S                  17 lines
> M arch/aarch64/vdso-pie.c                        +5, -17
> M arch/aarch64/vdso.c                            +6, -0
> M pie/Makefile                                   +3, -0
> M test/zdtm/live/static/vdso01.c                 +33, -38
> 
> Total                                            +78, -64
> 
> I think this illustrates that there are several hundred lines of code that
> could be common between architectures. If you're willing to go back to a
> mostly common code layout, what is the best way to proceed.

Hi Christopher! Thanks for analysis. I strongly against the common code
because any change in common part require testing over all archs. That
said mind to post the complete series of your changes lets see if we
may move some bits to common part in a safe way.


More information about the CRIU mailing list