[CRIU] [PATCH 4/4] RFC: Make ZDTM run on embedded root filesystems

[Pavel Emelyanov]

On 07/11/2014 12:59 AM, Christopher Covington wrote:
> Hi Andrew,
> 
> On 07/10/2014 04:13 PM, Andrew Vagin wrote:
>> On Thu, Jul 10, 2014 at 11:09:07AM -0400, Christopher Covington wrote:
>>> Modify the ZDTM script so that it can run on minimalistic root
>>> filesystems without much more than busybox.
>>
>> Is it really needed?
> 
> It would make testing changes across multiple architectures a lot easier. What
> root filesystems do you use for testing? What are the cumulative disk space
> and boot time requirements? On AArch64 for example the OpenEmbedded root
> filesystem from Linaro took forever to boot on simulators last time I checked.
> Running busybox init is way faster.
> 
> In my opinion, the easier it is to run the tests, the more often they will be
> run and the higher quality CRIU will become.

I agree. Andrey, please, help with the patch.

Chrisopher, I have one question about one:

>  check_mainstream()
>  {
> -	local -a ver_arr
> -	local ver_str=`uname -r`
> -
> -	zdtm_sep "CRIU CHECK"
> -
> -	$CRIU check && return 0
> -	MAINSTREAM_KERNEL=1
> -
> -	cat >&2 <<EOF
> -============================= WARNING =============================
> -Not all features needed for CRIU are merged to upstream kernel yet,
> -so for now we maintain our own branch which can be cloned from:
> -git://git.kernel.org/pub/scm/linux/kernel/git/gorcunov/linux-cr.git
> -===================================================================
> -EOF
> -
> -	ver_arr=(`echo ${ver_str//./ }`)
> -
> -	[ "${ver_arr[0]}" -gt 3 ] && return 0
> -	[[ "${ver_arr[0]}" -eq 3 && "${ver_arr[1]}" -ge 11 ]] && return 0
> -
> -	echo "A version of kernel should be greater or equal to 3.11" >&2
> -
> -	return 1
> +	return 0
>  }

Some checks on the kernel being >= 3.11 should be preserved, I think.
The usage of older kernels is still quite big, and it's better to
warn user about it in advance.

What exactly doesn't work here in your setup?

Thanks,
Pavel