[CRIU] [avagin at openvz.org: [PATCH] tcp: don't forget to wake up the port->users futex]

[Robert Reinecke]

Thank you very much for the fast reply! That fixed it!

Could you provide a short explanation?

Btw. I observed that you run into problems when trying run multiple
instances of criu at the same time (e.g. restoring an dumping multiple
processes) - any guesses there where to search? I would be happy to
contribute.


2014-07-07 14:05 GMT+02:00 Andrew Vagin <avagin at parallels.com>:
> Hi,
>
> Robert, could you try out this patch. It should fix your problem.
>
>
> ---------- Weitergeleitete Nachricht ----------
> From: Andrey Vagin <avagin at openvz.org>
> To: <criu at openvz.org>
> Cc: Pavel Emelyanov <xemul at parallels.com>, Andrey Vagin <avagin at openvz.org>
> Date: Mon, 7 Jul 2014 15:31:08 +0400
> Subject: [PATCH] tcp: don't forget to wake up the port->users futex
> Reported-by: Robert Reinecke <reinecke at rbg.informatik.tu-darmstadt.de>
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  sk-inet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sk-inet.c b/sk-inet.c
> index 02c653f..a94cd41 100644
> --- a/sk-inet.c
> +++ b/sk-inet.c
> @@ -547,7 +547,7 @@ static int open_inet_sk(struct file_desc *d)
>                         inet_connect(sk, ii))
>                 goto err;
>  done:
> -       futex_dec(&ii->port->users);
> +       futex_dec_and_wake(&ii->port->users);
>
>         if (rst_file_params(sk, ie->fown, ie->flags))
>                 goto err;
> --
> 1.8.5.3
>
>