[CRIU] [PATCH 4/4] zdtm: Introduce per-test criu options

Pavel Emelyanov xemul at parallels.com
Tue Jul 1 07:44:01 PDT 2014


On 07/01/2014 06:39 PM, Cyrill Gorcunov wrote:
> On Tue, Jul 01, 2014 at 06:30:07PM +0400, Pavel Emelyanov wrote:
>> Some tests require custom options for dump and restore. Instead
>> of hard-coding test names into zdth.sh, introduce the $test.opts
>> file from which zdtm would pick the needed options.
>>
>> Signed-off-by: Pavel Emelyanov <xemul at parallels.com>
> 
> Maybe we could rather put options into the testfile itself, something
> like
> 
> /*
>  * criu-opts: --D ...
>  */
> 
> the simply grep for it?
> .
> 

Could work too. I'd prefer separate file, since manual dumping would be as easy as 

   criu dump -t $pid $(cat $test.opts)

instead of more complicated 

   criu dump -t $pid $(cat $test.c | fgrep 'criu-opts:' | sed -e 's/^.*criu-opts://')

:)


More information about the CRIU mailing list