[CRIU] [PATCH] Doc/Makefile: error out if req tools absent

Cyrill Gorcunov gorcunov at gmail.com
Mon Jan 20 02:38:47 PST 2014


On Mon, Jan 20, 2014 at 02:20:10PM +0400, Pavel Emelyanov wrote:
> > +.PHONY: check
> 
> Patch doesn't apply. It conflicts with 19ea709e (Doc/Makefile: add ps
> and pdf generation)

Updated

-------------- next part --------------
From: Kir Kolyshkin <kir at openvz.org>
Subject: [PATCH] Doc/Makefile: error out if req tools absent

Make sure we have a clear message why build it failing, as there are
repeated questions at criu@ mailing list.

Before this patch:

	[kir at kirpad Documentation]$ make
	  GEN      criu.8
	make: *** [criu.8] Error 127

After:

	[kir at kirpad Documentation]$ make
	/bin/sh: line 1: xmltos: command not found
	make: *** [check] Error 1

Signed-off-by: Kir Kolyshkin <kir at openvz.org>
Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 Documentation/Makefile | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 1a98801d54b3..50e4526c9477 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -16,10 +16,15 @@ GROFF_OPTS	:= -Tps -t -dpaper=$(PAPER) -P-p$(PAPER) \
 PSS		:= $(MANS:%.8=%.ps)
 PDFS		:= $(MANS:%.8=%.pdf)
 
-all: $(MANS)
+all: check $(MANS)
 ps: $(PSS)
 pdf: $(PDFS)
-.PHONY: all ps pdf
+.PHONY: all ps pdf check
+
+check:
+	$(Q) for B in $(ASCIIDOC) $(A2X) $(XMLTO); do	\
+		$$B --version > /dev/null || exit 1;	\
+	done
 
 %.8: %.txt
 	$(E) "  GEN     " $@
-- 
1.8.3.1



More information about the CRIU mailing list