[CRIU] criu-1.1-rc1 segfaults on fedora 20 x86_64

[Pavel Emelyanov]

On 01/04/2014 11:32 PM, Neal Becker wrote:
> I'm assuming that "can't collect mount tree" is harmless??

Where do you see it? I thought (from your previous mail) that the
patch helped and criu check worked OK.

> 
> On Sat, Jan 4, 2014 at 2:31 PM, Neal Becker <ndbecker2 at gmail.com <mailto:ndbecker2 at gmail.com>> wrote:
> 
>     sudo crtools check --ms
>     (00.081409) Warn  (tun.c:55): Skipping tun support check
>     Looks good.
> 
>     Patch did not apply, I used this:
> 
> 
> 
>     On Sat, Jan 4, 2014 at 2:17 PM, Pavel Emelyanov <xemul at parallels.com <mailto:xemul at parallels.com>> wrote:
> 
>         On 01/04/2014 11:07 PM, Neal Becker wrote:
>         > Here's another view, generated by ABRT (automatic bug reporting tool)
>         >
>         > Core was generated by `criu check --ms'.
>         > Program terminated with signal SIGSEGV, Segmentation fault.
>         > #0  mount_resolve_path (path=0xd812a0 "/home/nbecker/.gnupg/S.gpg-agent") at mount.c:141
>         > 141list_for_each_entry(c, &m->children, siblings) {
>         >
>         > Thread 1 (Thread 0x7f1b37434740 (LWP 13862)):
>         > #0  mount_resolve_path (path=0xd812a0 "/home/nbecker/.gnupg/S.gpg-agent") at mount.c:141
>         >         __mptr = <optimized out>
>         >         pathlen = 32
>         >         m = 0x0
>         >         c = <optimized out>
> 
>         This one is helpful, thanks. Can you check whether this patch helps:
> 
>         diff --git a/cr-check.c b/cr-check.c
>         index 064d286..6074bfe 100644
>         --- a/cr-check.c
>         +++ b/cr-check.c
>         @@ -541,6 +541,11 @@ int cr_check(void)
>                         return -1;
>                 }
> 
>         +       if (collect_mount_info(getpid())) {
>         +               pr_err("Can't collect mount tree\n");
>         +               return -1;
>         +       }
>         +
>                 ret |= check_map_files();
>                 ret |= check_sock_diag();
>                 ret |= check_ns_last_pid();
> 
> 
>         If it does, I will apply it. Do you mind having your name and e-mail in the
>         Reported-by: tag in the CRIU repository?
> 
>         Thanks,
>         Pavel
> 
> 
>