[CRIU] [PATCH 1/2] pagemap-cache: Introduce engine

Cyrill Gorcunov gorcunov at gmail.com
Mon Feb 17 11:12:05 PST 2014


On Mon, Feb 17, 2014 at 10:16:27PM +0400, Pavel Emelyanov wrote:
> 
> > +#define PAGEMAP_LEN(pages)	((pages) * sizeof(u64))
> 
> This one always accepts only PAGEMAP_PFN() argument. Plz, make it work on size
> and do / PAGE_SIZE internally.

OK


> > +/* To carry up to 2M of physical memory */
> > +#define PMC_SHIFT		(21)
> > +#define PMC_SIZE		(1ul << PMC_SHIFT)
> > +#define PMC_MASK		(~(PMC_SIZE - 1))
> > +#define PMC_SIZE_GAP		(PMC_SIZE / 4)
> 
> This stuff is internal to pagemap-cache.c. Plz, leave in header only the API.

Sure


More information about the CRIU mailing list