[CRIU] [RFC 2/2] mem: Start using pagemap cache

Pavel Emelyanov xemul at parallels.com
Thu Feb 13 03:50:11 PST 2014


On 02/13/2014 03:43 PM, Cyrill Gorcunov wrote:
> On Thu, Feb 13, 2014 at 03:36:12PM +0400, Pavel Emelyanov wrote:
>>>  
>>> -	for (pfn = 0; pfn < nr_to_scan; pfn++) {
>>> -		unsigned long vaddr;
>>> +	for (; vaddr < vma->e->end; vaddr += PAGE_SIZE) {
>>
>> If you want to rename variables (with their meanings) send separate patch with it.
> 
> Hm? The cache is taking @vaddr as argument, it handles pfn insteranly. So
> meaning of @vaddr is not cahcnged -- it was carrying virtual address before
> this patch and does the same with this patch.
> .

Old loop works with PFN-s, you want vaddrs instead. OK, make the
patch that does _just_ so.


More information about the CRIU mailing list