[CRIU] [PATCH] restore: Compute auxv size taking into account kernel's mm::saved_auxv type

Pavel Emelyanov xemul at parallels.com
Mon Feb 10 04:03:38 PST 2014


On 02/10/2014 03:58 PM, Cyrill Gorcunov wrote:
> On Mon, Feb 10, 2014 at 03:57:32PM +0400, Cyrill Gorcunov wrote:
>> On Mon, Feb 10, 2014 at 03:55:46PM +0400, Pavel Emelyanov wrote:
>>>>>>
>>>>>> that's because in commit 459828b6bec92d664bcce8419436e528be2094f2
>>>>>> we've changed reading procedure of auxv but forgot to update
>>>>>> restore procedure (which were thinking that size of vector
>>>>>> remains in number of "passes".
>>>>>
>>>>> IOW, we broke backward compatibility, right?
>>>>
>>>> Yes, sort of. 
>>>
>>> Than return one back please.
>>
>> Revert commit 459828b6be please.

No way.

> I mean -- drop this patch and revert the former commit.
> We rather need to continue reading auxv as it were before.

No, we don't. Read the whole buffer in one go into temp buffer
and parse it (if required).

> 	Cyrill
> .
> 




More information about the CRIU mailing list