[CRIU] [PATCH] Makefile: fix libcriu.so links and man page installation

Adrian Reber adrian at lisas.de
Sun Feb 9 05:39:05 PST 2014


On Fri, Feb 07, 2014 at 10:24:56AM -0500, Christopher Covington wrote:
> On 02/07/2014 10:18 AM, Adrian Reber wrote:
> > 
> > The links to the versioned libcriu.so.* included $(DESTDIR) and
> > $(LIBDIR) which will generate wrong links if building criu packages.
> > Now the links points to the correct file without any path.
> > 
> > For some reason criu.8 was installed with executable permission. Use
> > 'install' with '-m 644' to make sure this does not happen.
> 
> I would suggest symbolic notation such as a=r for easier comprehension.

Hmm, that is probably something very subjective. For me the octal
notation is easier to read and write. As the remaining Makefiles are
also using octal notation I would not change it here. I would leave it
to the upstream criu maintainers do decide how they like it better.

		Adrian


More information about the CRIU mailing list