[CRIU] [RFC 11/11] Make sure sed fixups are carried out

Christopher Covington cov at codeaurora.org
Fri Feb 7 09:04:45 PST 2014


The following issue is possibly caused by using busybox make.

protobuf/packet-sock.pb-c.c: In function 'packet_sock_entry__init':
protobuf/packet-sock.pb-c.c:98:3: error: this decimal constant is unsigned only in ISO C90 [-Werror]

Use a belt-and-suspenders approach to ensure it doesn't happen.
---
 protobuf/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/protobuf/Makefile b/protobuf/Makefile
index 2bfd696..a1a3fe8 100644
--- a/protobuf/Makefile
+++ b/protobuf/Makefile
@@ -86,7 +86,9 @@ $(obj)/%.pb-c.c $(obj)/%.pb-c.h: $(obj)/%.proto $(obj)/%.proto.c.d
 	$(E) "  PBCC    " $@
 	$(Q) protoc-c --proto_path=$(obj)/ --c_out=$(obj)/ $<
 ifeq ($(ARCH),arm)
-	$(Q) sed -i -e 's/4294967295/0xFFFFFFFF/g' $@ $(patsubst %.h,%.c,$@)
+	$(Q) sed -i -e 's/4294967295/0xFFFFFFFF/g' $@
+	$(Q) sed -i -e 's/4294967295/0xFFFFFFFF/g' $(patsubst %.c,%.h,$@)
+	$(Q) sed -i -e 's/4294967295/0xFFFFFFFF/g' $(patsubst %.h,%.c,$@)
 endif
 
 $(obj)/%.o: $(obj)/%.pb-c.c $(obj)/%.pb-c.h
-- 
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by the Linux Foundation.



More information about the CRIU mailing list