[CRIU] [PATCH] service: add default pidfile name

[Ruslan Kuprieiev]

On 06.02.2014 05:26, Kir Kolyshkin wrote:
> On 02/05/2014 07:26 AM, Ruslan Kuprieiev wrote:
>> It is right for deamon to store pidfile at /var/run/ by default.
>>
>> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
>
> Looks good to me, although I notice that you do not document it.
> I think it should be documented in the man page, under the crui service
> command description. The problem is criu service section still needs
> to be written...

Yes, you are right. Just let me add few more features to service and I 
will add
detailed service section to manpage.

>
>> ---
>>   cr-service.c               | 3 +++
>>   include/cr-service-const.h | 1 +
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/cr-service.c b/cr-service.c
>> index 5f7f712..1f73101 100644
>> --- a/cr-service.c
>> +++ b/cr-service.c
>> @@ -590,6 +590,9 @@ int cr_service(bool daemon_mode)
>>               pr_perror("Can't run service server in the background");
>>               goto err;
>>           }
>> +
>> +        if (!opts.pidfile)
>> +            opts.pidfile = CR_DEFAULT_SERVICE_PIDFILE;
>>       }
>>         if (opts.pidfile) {
>> diff --git a/include/cr-service-const.h b/include/cr-service-const.h
>> index 668882b..dbeb8d0 100644
>> --- a/include/cr-service-const.h
>> +++ b/include/cr-service-const.h
>> @@ -3,5 +3,6 @@
>>     #define CR_MAX_MSG_SIZE 1024
>>   #define CR_DEFAULT_SERVICE_ADDRESS "/var/run/criu_service.socket"
>> +#define CR_DEFAULT_SERVICE_PIDFILE "/var/run/criu_service.pid"
>>     #endif /* __CR_SERVICE_CONST_H__ */
>