[CRIU] [PATCH] Makefile: add soname to libcriu.so

Pavel Emelyanov xemul at parallels.com
Wed Feb 5 07:08:32 PST 2014


On 02/05/2014 07:04 PM, Andrew Vagin wrote:
> On Wed, Feb 05, 2014 at 07:01:14PM +0400, Cyrill Gorcunov wrote:
>> On Wed, Feb 05, 2014 at 03:51:55PM +0100, Adrian Reber wrote:
>>>>> +VERSION_SO_MAJOR	:= 1
>>>>> +VERSION_SO_MINOR	:= 0
>>>>
>>>> Why VERSION_MAJOR + VERSION_MINOR is not enough?
>>>
>>> This really depends on the versioning scheme of criu. The soname only
>>> needs to change if the ABI is changed. If the developers of criu can
>>> guarantee that the ABI will not change as long as criu stays at version
>>> 1.x and will change once the version goes to 2.x then VERSION_MAJOR can
>>> be used. For now it would be possible to still use VERSION_MAJOR. I used
>>> VERSION_SO_MAJOR and VERSION_SO_MINOR to make clear that the soname
>>> versioning is independent of criu's version number. It can, of course,
>>> use VERSION_MAJOR and VERSION_MINOR and only if necessary be changed to
>>> different numbers in the future.
>>
>> I think we're not going to change ABI of library without changing major
>> number of criu itself. Pavel?
> 
> But we can change the major number of criu without changing ABI of
> library...

Yup :) So separate number for library makes sense to me.

>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
> .
> 




More information about the CRIU mailing list