[CRIU] [PATCH] Makefile: add soname to libcriu.so

[Adrian Reber]

On Wed, Feb 05, 2014 at 06:38:50PM +0400, Cyrill Gorcunov wrote:
> On Wed, Feb 05, 2014 at 03:28:17PM +0100, Adrian Reber wrote:
> > 
> > Using a soname makes it easy for applications to
> > detect if the ABI of libcriu.so has changed.
> > It still creates libcriu.so as before in lib. During
> > 'make install' additional links are created:
> > 
> >  libcriu.so -> libcriu.so.1.0
> >  libcriu.so.1 -> libcriu.so.1.0
> > 
> > Signed-off-by: Adrian Reber <adrian at lisas.de>
> > ---
> >  Makefile     | 15 ++++++++++++---
> >  lib/Makefile |  4 ++--
> >  2 files changed, 14 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 985b8c9..9ed45bd 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -3,8 +3,11 @@ VERSION_MINOR		:= 1
> >  VERSION_SUBLEVEL	:=
> >  VERSION_EXTRA		:=
> >  VERSION_NAME		:=
> > +VERSION_SO_MAJOR	:= 1
> > +VERSION_SO_MINOR	:= 0
> 
> Why VERSION_MAJOR + VERSION_MINOR is not enough?

This really depends on the versioning scheme of criu. The soname only
needs to change if the ABI is changed. If the developers of criu can
guarantee that the ABI will not change as long as criu stays at version
1.x and will change once the version goes to 2.x then VERSION_MAJOR can
be used. For now it would be possible to still use VERSION_MAJOR. I used
VERSION_SO_MAJOR and VERSION_SO_MINOR to make clear that the soname
versioning is independent of criu's version number. It can, of course,
use VERSION_MAJOR and VERSION_MINOR and only if necessary be changed to
different numbers in the future.

		Adrian