[CRIU] [PATCH 5/5] mm: Move VmaEntries from separate image into Mm one

[Pavel Emelyanov]

On 02/04/2014 11:37 AM, Cyrill Gorcunov wrote:
> On Tue, Feb 04, 2014 at 11:34:34AM +0400, Pavel Emelyanov wrote:
>>>>  message mm_entry {
>>>>  	required uint64	mm_start_code	=  1;
>>>>  	required uint64	mm_end_code	=  2;
>>>> @@ -13,4 +15,6 @@ message mm_entry {
>>>>  	required uint32	exe_file_id	= 12;
>>>>  
>>>>  	repeated uint64	mm_saved_auxv	= 13;
>>>> +
>>>> +	repeated vma_entry vmas		= 14;
>>>
>>> The whole series looks good to me. Except this one -- I managed
>>> to forgot: is "repeated" entry is optional or required?
>>
>> Optional, as n_foo can be zero.
> 
> I mean the case where img file created with new proto would be trying to
> read by older version of criu, won't proto reader get corruption here?

According to spec -- shouldn't. I'll try with zdtm backward compat testing.