[CRIU] [PATCH 5/5] mm: Move VmaEntries from separate image into Mm one

[Pavel Emelyanov]

On 02/04/2014 10:34 AM, Cyrill Gorcunov wrote:
> On Tue, Feb 04, 2014 at 12:09:00AM +0400, Pavel Emelyanov wrote:
>> When writing VMAs we perform too many small writes into vma-.img files.
>> This can be easily fixed by moving the vma-s into mm-s, all the more
>> so they cannot be splitted from each other.
>>
>> Signed-off-by: Pavel Emelyanov <xemul at parallels.com>
> ...
>> --- a/protobuf/mm.proto
>> +++ b/protobuf/mm.proto
>> @@ -1,3 +1,5 @@
>> +import "vma.proto";
>> +
>>  message mm_entry {
>>  	required uint64	mm_start_code	=  1;
>>  	required uint64	mm_end_code	=  2;
>> @@ -13,4 +15,6 @@ message mm_entry {
>>  	required uint32	exe_file_id	= 12;
>>  
>>  	repeated uint64	mm_saved_auxv	= 13;
>> +
>> +	repeated vma_entry vmas		= 14;
> 
> The whole series looks good to me. Except this one -- I managed
> to forgot: is "repeated" entry is optional or required?

Optional, as n_foo can be zero.