[CRIU] [PATCH] timerfd: show procfs fdinfo helper

[shawn at churchofgit.com]

---- Original Message ----
 From: "Andrey Wagin" 
 To: "Shawn Landden" 
CC: "LKML" , "criu at openvz.org" , "Alexander Viro" , linux-fsdevel at vger.kernel.org, "Thomas Gleixner" 
 Sent: Wed, Dec 25, 2013, 12:46 AM
 Subject: Re: [CRIU] [PATCH] timerfd: show procfs fdinfo helper
2013/12/24 Shawn Landden :
| pos:  0
| flags:        02004002
| clockid:      0

Cc: Thomas Gleixner 
Cc: Alexander Viro 
Signed-off-by: Shawn Landden 
---
fs/timerfd.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/fs/timerfd.c b/fs/timerfd.c
index 9293121..e5fa587 100644
--- a/fs/timerfd.c
+++ b/fs/timerfd.c
@@ -25,6 +25,7 @@
#include 
#include 
#include 
+#include 

struct timerfd_ctx {
union {
@@ -284,7 +285,23 @@ static ssize_t timerfd_read(struct file *file, char __user *buf, size_t count,
return res;
}

+#ifdef CONFIG_PROC_FS
+static int timerfd_show_fdinfo(struct seq_file *m, struct file *f)
+{
+       struct timerfd_ctx *ctx = f->private_data;
+       int clockid;
+
+       clockid = ctx->clockid;
+       seq_printf(m, "clockid:t%dn", clockid);

I think we can show ctx->ticks, itimerspec here. The ctx->ticks is
required for proper dumping and restoring timerfd.

How? Shouldn't the itemerspec (from  timerfd_gettime and restored with timerfd_settime) and clockid be enough? How do we put the ctx->ticks back into the restored timerfd if we get it out with procfs?
+
+       return 0;
+}
+#endif
+
static const struct file_operations timerfd_fops = {
+#ifdef CONFIG_PROC_FS
+       .show_fdinfo    = timerfd_show_fdinfo,
+#endif
.release        = timerfd_release,
.poll           = timerfd_poll,
.read           = timerfd_read,
--
1.8.5.2.297.g3e57c29

_______________________________________________
CRIU mailing list
CRIU at openvz.org (mailto:CRIU at openvz.org)
https://lists.openvz.org/mailman/listinfo/criu (https://lists.openvz.org/mailman/listinfo/criu)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20140203/664a1dad/attachment.html>