[CRIU] [PATCH] zdtm.sh: set correct path for dump files
Christopher Covington
cov at codeaurora.org
Fri Dec 19 08:01:44 PST 2014
Hi Andrey,
On 12/19/2014 07:55 AM, Andrey Vagin wrote:
> Don't use an uninitialized variable to create a path pattern.
>
> Cc: Christopher Covington <cov at codeaurora.org>
> Reported-by: Christopher Covington <cov at codeaurora.org>
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
> test/zdtm.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/zdtm.sh b/test/zdtm.sh
> index 3627fec..e5cb4cf 100755
> --- a/test/zdtm.sh
> +++ b/test/zdtm.sh
> @@ -655,7 +655,8 @@ EOF
> gen_args="$gen_args --force-irmap"
> fi
>
> - ddump=`readlink -fm dump/$test_name/$PID/$i`
> + # X will be substituted on an iteration number
Maybe "with an iteration number" or "on each iteration".
> + ddump=`readlink -fm dump/$test_name/$PID/X`
If you drop the readlink -m, busybox will be able to run this script. I can
resubmit my patch for this if you prefer.
> [ -n "$PERF" ] && gen_args="$gen_args --action-script $SCRIPTDIR/perf-script.sh"
>
Thanks,
Chris
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
More information about the CRIU
mailing list