[CRIU] [PATCH] zdtm: fallback to mknod(/dev/ptmx) when CONFIG_DEVPTS_MULTIPLE_INSTANCES is not set

Filipe Brandenburger filbranden at google.com
Wed Aug 27 04:46:07 PDT 2014


Hi Andrey,

On Wed, Aug 27, 2014 at 12:59 AM, Andrew Vagin <avagin at parallels.com> wrote:
>>               if (mount("pts", "/dev/pts", "devpts", MS_MGC_VAL, "mode=666,ptmxmode=666,newinstance")) {
>
> It's strange, that mount with newinstance doesn't fail, if
> CONFIG_DEVPTS_MULTIPLE_INSTANCES

It doesn't fail... I get this message "devpts: called with bogus
options" in dmesg but the mount works and I get the global devpts
inside the namespace.

The zdtm tests for pty/tty do not work but the other ns/* tests work
fine as otherwise they would fail around here bind mounting ptmx on
top of itself...

Thanks for the quick review!

Cheers,
Filipe


More information about the CRIU mailing list