[CRIU] [PATCH] crtools: bump up the getopt return values to outside the ascii range

Pavel Emelyanov xemul at parallels.com
Tue Aug 26 01:50:03 PDT 2014


On 08/26/2014 11:47 AM, Andrew Vagin wrote:
> On Mon, Aug 25, 2014 at 09:08:06PM -0700, Filipe Brandenburger wrote:
>> The return values were getting dangerously close to the range of meaningful
>> values, in particular the next candidate 63 is equal to '?' which is the
>> typical return value in case of error.
>>
>> The return values for long options may be any integer, so bump them up to
>> outside the ascii range, start above 1000. For ease of review this patch, keep
>> the existing range (41-62) and increment each value by 1000.
>>
>> Tested:
>> - Ran "criu --help", works fine.
>> - Manual dump and restore with some of the options, worked fine.
>> - Ran the zdtm test suite, tests passed.
>>
> 
> Acked-by: Andrew Vagin <avagin at parallels.com>
>  
>> Signed-off-by: Filipe Brandenburger <filbranden at google.com>

Applied, thanks everyone!



More information about the CRIU mailing list