[CRIU] tty error when dumping restored container

[Cyrill Gorcunov]

On Mon, Aug 18, 2014 at 08:49:19AM -0500, Tycho Andersen wrote:
> > 
> > dump/restore logs for both passes please
> 
> Logs are attached.

So on restore we have

(00.291660)      1: tty: Hungup terminal found id 58
(00.291664)      1: tty: head type pts id 0x8c index 8 (master 0 sid 0 pgrp 0 inherit 0)
(00.291667)      1: tty:     `- sibling type ptmx id 0xc index 8 (master 1 sid 0 pgrp 0 inherit 0)
(00.291670)      1: tty: head type pts id 0x8a index 6 (master 0 sid 0 pgrp 0 inherit 0)
(00.291673)      1: tty:     `- sibling type ptmx id 0xa index 6 (master 1 sid 0 pgrp 0 inherit 0)
(00.291675)      1: tty: head type pts id 0x6e index 3 (master 0 sid 0 pgrp 0 inherit 0)
(00.291678)      1: tty:     `- sibling type ptmx id 0xe index 3 (master 1 sid 0 pgrp 0 inherit 0)
(00.291681)      1: tty: head type pts id 0x6b index 2 (master 0 sid 0 pgrp 0 inherit 0)
(00.291684)      1: tty:     `- sibling type ptmx id 0xd index 2 (master 1 sid 0 pgrp 0 inherit 0)
(00.291686)      1: tty: head type pts id 0x67 index 0 (master 0 sid 0 pgrp 0 inherit 0)
(00.291689)      1: tty:     `- sibling type ptmx id 0xb index 0 (master 1 sid 0 pgrp 0 inherit 0)
(00.291692)      1: tty: head type pts id 0x58 index 5 (master 0 sid 0 pgrp 0 inherit 0)
(00.291695)      1: tty: Found orphan slave fake leader (0x58)

You;ve a pty which master peer is closed already and its file descriptor just kept by some
application. On second dump criu finds descriptor but can't fetch any data from it because it's
"hungup'ed". I think this is a nit in criu, will take a look once time permit.